Fork me on GitHub

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#61 closed Bug (fixed)

Isolation routine does not compute closest track correctly

Reported by: Sourav Mandal Owned by:
Priority: major Milestone:
Component: Delphes code Version:
Keywords: Cc:

Description

We at IPMU found another bug in the isolation routine (RESOLution::Isolation in src/SmearUtil.cc:1429). While the previous bug (Ticket #46) skipped tracks inside the isolation cone, giving a wrong result for ptiso, there is another bug that causes it to not find the closes tracking, giving the wrong result for the isolation flag.

On line 1440, the saved smallest DeltaR ("deltar") is being overwritten by the current DeltaR ("genDeltaR") on *every track*. This should only occur for the current track if genDeltaR < deltar.

A patch against Delphes 2.0.2 is attached.

PS: I mistakenly attached this patch to Ticket #46; please delete it.

Attachments (1)

delphes-isolation.patch (720 bytes ) - added by Sourav Mandal 12 years ago.

Download all attachments as: .zip

Change History (4)

by Sourav Mandal, 12 years ago

Attachment: delphes-isolation.patch added

comment:1 by Sourav Mandal, 12 years ago

"closes tracking" -> "closest track"

comment:2 by favereau, 12 years ago

Resolution: fixed
Status: newclosed

Hi,

Your patched has been merged and will be included in the next release.

Thanks !

in reply to:  2 comment:3 by anonymous, 12 years ago

Replying to favereau: play casino

Hi,

Your patched has been merged and will be included in the next release.

Thanks !

Great thanks.

Note: See TracTickets for help on using tickets.