Fork me on GitHub

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#46 closed Bug (fixed)

Isolation routine mistakenly rejects tracks inside isolation cone

Reported by: Sourav Mandal Owned by:
Priority: major Milestone:
Component: Delphes code Version: all recent versions (> 1.8)
Keywords: Cc:

Description

In RESOLution::Isolation (src/SmearUtil.cc:1429), the algorithm rejects tracks that are inside the isolation code but happen to not be the closest neighbor track. This saves a bit of time in finding the closest neighbor track, but badly miscalculates ptiso .

The fix for this is to comment out Line 1440; I am attaching a patch that does this.

Attachments (2)

delphes-ptiso.patch (661 bytes ) - added by Sourav Mandal 13 years ago.
delphes-isolation.patch (720 bytes ) - added by Sourav Mandal 12 years ago.

Download all attachments as: .zip

Change History (5)

by Sourav Mandal, 13 years ago

Attachment: delphes-ptiso.patch added

comment:1 by favereau, 13 years ago

Hi,

Thanks for the report, after some thinking I agree with you that we should only exclude the particle track and no other tracks in the cone. I will merge this patch into the next minor release.

comment:2 by favereau, 13 years ago

Resolution: fixed
Status: newclosed

comment:3 by Sourav Mandal, 12 years ago

BTW, the credit for this fix should go to my colleague at IPMU, Biplob Bhattacherjee

by Sourav Mandal, 12 years ago

Attachment: delphes-isolation.patch added
Note: See TracTickets for help on using tickets.