Phi/Energy dependence in efficiencies

[Daschm]

Hi again,

I think there is a bug (or more like a "non-working potential feature") in your Efficiencies module:

According to Efficiencies.cc and DelphesFormula.cc/h, you allow for the parameters "phi" and "energy" in the efficiency formulae given in the detector card. However, due to the line which calls the Eval part

    eta = candidatePosition.Eta();
    phi = candidatePosition.Phi();
    pt = candidateMomentum.Pt();

    // apply an efficency formula
    if(gRandom->Uniform() > fFormula->Eval(pt, eta)) continue;

the candidate's phi and energy are not used for the actual evaluation (but in fact they are set to the standard values of 0, defined in DelphesFormula::Eval()). Unfortunately, using a phi/eta-dependent efficiency function does not even lead to a run-time-error, but just that the efficiency is called with phi=0 every time.

Cheers
Daniel

[Michele Selvaggi]

Hi Daniel,

thanks for spotting this issue. It is fixed now in all relevant modules.

Cheers,
Michele