Fork me on GitHub

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#37 closed Bug (fixed)

Analysis_Ex bug

Reported by: hashemi.mj@… Owned by: favereau
Priority: major Milestone:
Component: Delphes code Version:
Keywords: Cc:

Description

Hello,

As a user of Delphes V1.9, running on SLC 5.7, 64-bit, with ROOT 5.30, I get a crash when running Analysis_Ex.

I found a problem in line 90 of Examples/Analysis_Ex.cpp.
In my opinion checking the file goodness should be done before reading the buffer.
According to the above, the solution below works for me, so if you think it is right please fix the code in new versions.

while(1)
{
if(!infile.good()) break;
infile >> buffer;
chainGen.Add(buffer.c_str());
chainRec.Add(buffer.c_str());
chainTrig.Add(buffer.c_str());
}

Change History (5)

comment:1 by favereau, 13 years ago

Owner: set to favereau
Status: newassigned

Thanks for the report, we will include this in the official version asap.

comment:2 by favereau, 13 years ago

Resolution: fixed
Status: assignedclosed

The patch was introduced in the trunk. It will be included in the next relase.

Cheers,

Jerome

comment:3 by favereau, 13 years ago

Resolution: fixed
Status: closedreopened

comment:4 by favereau, 13 years ago

Resolution: fixed
Status: reopenedclosed

comment:5 by anonymous, 13 years ago

spam

Last edited 13 years ago by favereau (previous) (diff)
Note: See TracTickets for help on using tickets.