Changeset 9f38d6a in git

Timestamp:

Nov 20, 2015, 2:36:11 PM (9 years ago)

Author:

Michele Selvaggi <michele.selvaggi@…>

Branches:

ImprovedOutputFile, Timing, dual_readout, llp, master

Children:

fdfe022

Parents:

554a3b3 (diff), 7312b4d (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of ​https://github.com/delphes/delphes

Files:

• CHANGELOG (modified) (1 diff)
• cards/delphes_card_ATLAS_PileUp.tcl (modified) (3 diffs)
• cards/delphes_card_CMS_PileUp.tcl (modified) (3 diffs)
• modules/Isolation.cc (modified) (5 diffs)
• modules/Isolation.h (modified) (1 diff)
• modules/TrackPileUpSubtractor.cc (modified) (4 diffs)
• modules/TrackPileUpSubtractor.h (modified) (1 diff)

CHANGELOG

@@ -5 +5 @@
 - added example for pileup generation with Pythia8
 - moved to loose isolation working points for ATLAS and CMS cards
-- moved to pile-up density (rho) corrected isolation variable as default
+- added UseRhoCorrection switch to decide which isolation variable use for selection (true by default)
 - switch to Rapidity selector (SelectorRapRange) for pile-up density computation in FastJet to ensure backward compatibility
 - addressed N-subjettiness warnings in 2.2.1 version

cards/delphes_card_ATLAS_PileUp.tcl

@@ -500 +500 @@
 module Isolation PhotonIsolation {
   set CandidateInputArray PhotonEfficiency/photons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 
@@ -535 +535 @@
 module Isolation ElectronIsolation {
   set CandidateInputArray ElectronEfficiency/electrons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 
@@ -570 +570 @@
 module Isolation MuonIsolation {
   set CandidateInputArray MuonEfficiency/muons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 

cards/delphes_card_CMS_PileUp.tcl

@@ -534 +534 @@
 module Isolation PhotonIsolation {
   set CandidateInputArray PhotonEfficiency/photons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 
@@ -569 +569 @@
 module Isolation ElectronIsolation {
   set CandidateInputArray ElectronEfficiency/electrons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 
@@ -606 +606 @@
 module Isolation MuonIsolation {
   set CandidateInputArray MuonEfficiency/muons
-  set IsolationInputArray EFlowMerger/eflow
+  set IsolationInputArray EFlowMergerAllTracks/eflow
   set RhoInputArray Rho/rho
 

modules/Isolation.cc

@@ -108 +108 @@
 
   fUsePTSum = GetBool("UsePTSum", false);
+
+  fUseRhoCorrection = GetBool("UseRhoCorrection", true);
 
   fClassifier->fPTMin = GetDouble("PTMin", 0.5);
@@ -153 +155 @@
   Candidate *candidate, *isolation, *object;
   TObjArray *isolationArray;
-  Double_t sumCharged, sumNeutral, sumAllParticles, sumChargedPU, sumDBeta, ratioDBeta, sumRhoCorr, ratioRhoCorr;
+  Double_t sumChargedNoPU, sumChargedPU, sumNeutral, sumAllParticles;
+  Double_t sumDBeta, ratioDBeta, sumRhoCorr, ratioRhoCorr, sum, ratio;
   Int_t counter;
   Double_t eta = 0.0;
@@ -188 +191 @@
 
     // loop over all input tracks
-    
+
     sumNeutral = 0.0;
-    sumCharged = 0.0;
+    sumChargedNoPU = 0.0;
     sumChargedPU = 0.0;
     sumAllParticles = 0.0;
-   
+
     counter = 0;
     itIsolationArray.Reset();
-    
+
     while((isolation = static_cast<Candidate*>(itIsolationArray.Next())))
     {
@@ -205 +208 @@
       {
         sumAllParticles += isolationMomentum.Pt();
-        if(isolation->Charge !=0) 
-        { 
-          sumCharged += isolationMomentum.Pt();
-          if(isolation->IsRecoPU != 0) sumChargedPU += isolationMomentum.Pt();
-        } 
+        if(isolation->Charge != 0)
+        {
+          if(isolation->IsRecoPU)
+          {
+            sumChargedPU += isolationMomentum.Pt();
+          }
+          else
+          {
+            sumChargedNoPU += isolationMomentum.Pt();
+          }
+        }
         else
-        {
-          sumNeutral += isolationMomentum.Pt();
+        {
+          sumNeutral += isolationMomentum.Pt();
         }
         ++counter;
@@ -232 +241 @@
     }
 
-     // correct sum for pile-up contamination
-    sumDBeta = sumCharged + TMath::Max(sumNeutral-0.5*sumChargedPU,0.0);
-    sumRhoCorr = sumCharged + TMath::Max(sumNeutral-TMath::Max(rho,0.0)*fDeltaRMax*fDeltaRMax*TMath::Pi(),0.0);
+    // correct sum for pile-up contamination
+    sumDBeta = sumChargedNoPU + TMath::Max(sumNeutral - 0.5*sumChargedPU, 0.0);
+    sumRhoCorr = sumChargedNoPU + TMath::Max(sumNeutral - TMath::Max(rho, 0.0)*fDeltaRMax*fDeltaRMax*TMath::Pi(), 0.0);
     ratioDBeta = sumDBeta/candidateMomentum.Pt();
     ratioRhoCorr = sumRhoCorr/candidateMomentum.Pt();
-    
+
     candidate->IsolationVar = ratioDBeta;
     candidate->IsolationVarRhoCorr = ratioRhoCorr;
-    candidate->SumPtCharged = sumCharged;
+    candidate->SumPtCharged = sumChargedNoPU;
     candidate->SumPtNeutral = sumNeutral;
     candidate->SumPtChargedPU = sumChargedPU;
     candidate->SumPt = sumAllParticles;
 
-    if((fUsePTSum && sumRhoCorr > fPTSumMax) || (!fUsePTSum && ratioRhoCorr > fPTRatioMax)) continue;
+    sum = fUseRhoCorrection ? sumRhoCorr : sumDBeta;
+    if(fUsePTSum && sum > fPTSumMax) continue;
+
+    ratio = fUseRhoCorrection ? ratioRhoCorr : ratioDBeta;
+    if(!fUsePTSum && ratio > fPTRatioMax) continue;
+
     fOutputArray->Add(candidate);
   }

modules/Isolation.h

@@ -59 +59 @@
   Bool_t fUsePTSum;
 
+  Bool_t fUseRhoCorrection;
+
   IsolationClassifier *fClassifier; //!
 

modules/TrackPileUpSubtractor.cc

@@ -67 +67 @@
 void TrackPileUpSubtractor::Init()
 {
-// import input array
+  // import input array
 
   fVertexInputArray = ImportArray(GetString("VertexInputArray", "PileUpMerger/vertices"));
   fItVertexInputArray = fVertexInputArray->MakeIterator();
-  
+
   fZVertexResolution  = GetDouble("ZVertexResolution", 0.005)*1.0E3;
 
   fPTMin = GetDouble("PTMin", 0.);
+
   // import arrays with output from other modules
-   
+
   ExRootConfParam param = GetParam("InputArray");
   Long_t i, size;
@@ -119 +120 @@
   Double_t z, zvtx=0;
 
-  
+
   // find z position of primary vertex
-  
+
   fItVertexInputArray->Reset();
   while((candidate = static_cast<Candidate*>(fItVertexInputArray->Next())))
@@ -127 +128 @@
     if(!candidate->IsPU)
     {
-    zvtx = candidate->Position.Z();
-    // break;
+      zvtx = candidate->Position.Z();
+      // break;
     }
   }
@@ -144 +145 @@
       particle = static_cast<Candidate*>(candidate->GetCandidates()->At(0));
       z = particle->Position.Z();
-      
+
       // apply pile-up subtraction
       // assume perfect pile-up subtraction for tracks outside fZVertexResolution
-      
-      if(candidate->IsPU && TMath::Abs(z-zvtx) > fZVertexResolution) candidate->IsRecoPU = 1;
-      else 
+
+      if(candidate->IsPU && TMath::Abs(z-zvtx) > fZVertexResolution)
       {
-         candidate->IsRecoPU = 0;
-         if( candidate->Momentum.Pt() > fPTMin) array->Add(candidate);
+        candidate->IsRecoPU = 1;
+      }
+      else
+      {
+        candidate->IsRecoPU = 0;
+        if(candidate->Momentum.Pt() > fPTMin) array->Add(candidate);
       }
     }

modules/TrackPileUpSubtractor.h

@@ -50 +50 @@
   Double_t fZVertexResolution;
 
-  Double_t fPTMin; 
+  Double_t fPTMin;
 
   std::map< TIterator *, TObjArray * > fInputMap; //!