Changes in external/fastjet/contribs/Nsubjettiness/AxesDefinition.hh [b7b836a:973b92a] in git

File:

• external/fastjet/contribs/Nsubjettiness/AxesDefinition.hh (modified) (14 diffs)

external/fastjet/contribs/Nsubjettiness/AxesDefinition.hh

@@ -5 +5 @@
 //  Jesse Thaler, Ken Van Tilburg, Christopher K. Vermilion, and TJ Wilkason
 //
-//  $Id: AxesDefinition.hh 1130 2018-06-06 12:09:46Z jthaler $
+//  $Id: AxesDefinition.hh 833 2015-07-23 14:35:23Z jthaler $
 //----------------------------------------------------------------------
 // This file is part of FastJet contrib.
@@ -508 +508 @@
 /// \brief Wrapper for jet definitions (for memory management)
 ///
-/// This class is used by all AxesDefinition with a manual recombiner to
-/// ensure that the delete_recombiner_when_unused function is always called
+/// This class was introduced to avoid issue of a FastJet bug when using genKT clustering
+/// Now using this for all AxesDefinition with a manual recombiner to use the delete_recombiner_when_unused function
 ///------------------------------------------------------------------------
 class JetDefinitionWrapper {
@@ -549 +549 @@
    : ExclusiveJetAxes(JetDefinitionWrapper(fastjet::kt_algorithm,
                                           fastjet::JetDefinition::max_allowable_R, //maximum jet radius constant
-                                          new WinnerTakeAllRecombiner(), // Needs to be explicitly declared (this will be deleted by JetDefinitionWrapper)
+                                          _recomb = new WinnerTakeAllRecombiner(), // Needs to be explicitly declared (this will be deleted by JetDefinitionWrapper)
                                           fastjet::Best).getJetDef()
                       ) {
@@ -571 +571 @@
    virtual WTA_KT_Axes* create() const {return new WTA_KT_Axes(*this);}
 
+private:
+   const WinnerTakeAllRecombiner *_recomb;  ///< Internal recombiner
+
 };
    
@@ -585 +588 @@
    : ExclusiveJetAxes(JetDefinitionWrapper(fastjet::cambridge_algorithm,
                                              fastjet::JetDefinition::max_allowable_R, //maximum jet radius constant
-                                             new WinnerTakeAllRecombiner(), // Needs to be explicitly declared (this will be deleted by JetDefinitionWrapper)
+                                             _recomb = new WinnerTakeAllRecombiner(), // Needs to be explicitly declared (this will be deleted by JetDefinitionWrapper)
                                              fastjet::Best).getJetDef()) {
     setNPass(NO_REFINING);
@@ -605 +608 @@
    /// For copying purposes
    virtual WTA_CA_Axes* create() const {return new WTA_CA_Axes(*this);}
-  
+   
+private:
+   const WinnerTakeAllRecombiner *_recomb;  ///< Internal recombiner
+
 };
 
@@ -668 +674 @@
                                             R0,
                                             p,
-                                            new WinnerTakeAllRecombiner()
+                                            _recomb = new WinnerTakeAllRecombiner()
                                             ).getJetDef()), _p(p), _R0(R0) {
       if (p < 0) throw Error("WTA_GenKT_Axes:  Currently only p >=0 is supported.");
@@ -696 +702 @@
    double _p;   ///< genkT power
    double _R0;  ///< jet radius
+   const WinnerTakeAllRecombiner *_recomb; ///< Internal recombiner
 };
    
@@ -710 +717 @@
    /// Constructor
    GenET_GenKT_Axes(double delta, double p, double R0 = fastjet::JetDefinition::max_allowable_R)
-   : ExclusiveJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, new GeneralEtSchemeRecombiner(delta))).getJetDef() ),
+   : ExclusiveJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, _recomb = new GeneralEtSchemeRecombiner(delta))).getJetDef() ),
     _delta(delta), _p(p), _R0(R0) {
        if (p < 0) throw Error("GenET_GenKT_Axes:  Currently only p >=0 is supported.");
@@ -743 +750 @@
    double _p;     ///< GenkT power
    double _R0;    ///< jet radius
+   const GeneralEtSchemeRecombiner *_recomb;   ///< Internal recombiner
 };
 
@@ -1193 +1201 @@
    /// Constructor
    Comb_WTA_GenKT_Axes(int nExtra, double p, double R0 = fastjet::JetDefinition::max_allowable_R)
-   : ExclusiveCombinatorialJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, new WinnerTakeAllRecombiner())).getJetDef(), nExtra),
+   : ExclusiveCombinatorialJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, _recomb = new WinnerTakeAllRecombiner())).getJetDef(), nExtra),
     _p(p), _R0(R0) {
        if (p < 0) throw Error("Comb_WTA_GenKT_Axes:  Currently only p >=0 is supported.");
@@ -1219 +1227 @@
    double _p;        ///< GenkT power
    double _R0;       ///< jet radius
+   const WinnerTakeAllRecombiner *_recomb;   ///< Internal recombiner
 };
    
@@ -1232 +1241 @@
    /// Constructor
    Comb_GenET_GenKT_Axes(int nExtra, double delta, double p, double R0 = fastjet::JetDefinition::max_allowable_R)
-   : ExclusiveCombinatorialJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, new GeneralEtSchemeRecombiner(delta))).getJetDef(), nExtra),
+   : ExclusiveCombinatorialJetAxes((JetDefinitionWrapper(fastjet::genkt_algorithm, R0, p, _recomb = new GeneralEtSchemeRecombiner(delta))).getJetDef(), nExtra),
     _delta(delta), _p(p), _R0(R0) {
        if (p < 0) throw Error("Comb_GenET_GenKT_Axes:  Currently only p >=0 is supported.");
@@ -1262 +1271 @@
    double _p;        ///< GenkT power
    double _R0;       ///< jet radius
+   const GeneralEtSchemeRecombiner *_recomb;  ///<  Internal recombiner
 };